Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExtensionArray/Index/Series.repeat signature #24413

Closed
TomAugspurger opened this issue Dec 24, 2018 · 2 comments · Fixed by #24447
Closed

ExtensionArray/Index/Series.repeat signature #24413

TomAugspurger opened this issue Dec 24, 2018 · 2 comments · Fixed by #24447
Labels
API Design Blocker Blocking issue or pull request for an upcoming release ExtensionArray Extending pandas with custom dtypes or arrays.
Milestone
0.24.0

Comments

@TomAugspurger
Copy link
Contributor

In #24395 @jschendel mentioned that

I think this could be restricted to repeat(self, repeats, axis=None) but I opted to match on the least restrictive function signature instead.

I agree and I think we should do that.
@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Dec 24, 2018
@TomAugspurger TomAugspurger added ExtensionArray Extending pandas with custom dtypes or arrays. Blocker Blocking issue or pull request for an upcoming release labels Dec 24, 2018
@TomAugspurger TomAugspurger mentioned this issue Dec 24, 2018
Merged
@jreback
Copy link
Contributor

jreback commented Dec 24, 2018

agree here as well.

@jschendel jschendel changed the title ExtensionArray.repeat signature ExtensionArray/Index/Series.repeat signature Dec 25, 2018
@jschendel
Copy link
Member

Sounds good. Worth noting that this is would be identical to the signature for numpy.repeat, which makes sense to match. Was a little confused as to why we were using *args and **kwargs, but went with it since it was the existing convention. Can get to this in the next couple days.

@jschendel jschendel mentioned this issue Dec 26, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Design Blocker Blocking issue or pull request for an upcoming release ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Milestone
0.24.0
Development

Successfully merging a pull request may close this issue.

API: Simplify repeat signature jschendel/pandas
3 participants
@jreback @TomAugspurger @jschendel