Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit signature for NDFrame.to_hdf #20903

Closed
TomAugspurger opened this issue May 1, 2018 · 4 comments
Closed

Explicit signature for NDFrame.to_hdf #20903

TomAugspurger opened this issue May 1, 2018 · 4 comments
Labels
Docs IO HDF5 read_hdf, HDFStore

Comments

@TomAugspurger
Copy link
Contributor

Currently we have to_hdf(self, path_or_buf, key, **kwargs)

It'd be good to replace that with the actual signature (unless I'm missing a reason for the current implementation) and document it fully.

@abi-aryan
Copy link

I would love to help. How can I get started on this?

@TomAugspurger
Copy link
Contributor Author

Great! General contributing guidelines are at http://pandas-docs.github.io/pandas-docs-travis/contributing.html

For this specific one, I would look at to_hdf in pandas/pandas/io/pytables.py. Anywhere we pass kwargs currently (store.append and store.put) we'll need to figure out the correct set of keyword arguments expected. Some like mode, format, etc. will be straightforward. Others will take some digging. Let us know if you get stuck.

@abi-aryan
Copy link

Cool. On it now.

@jbrockmendel
Copy link
Member

Closed by #29957.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs IO HDF5 read_hdf, HDFStore
Projects
None yet
Development

No branches or pull requests

3 participants