Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FYI, if you build pandas release binaries with 3.6.1, they'll be broken on 3.6.0 #15961

Closed
njsmith opened this issue Apr 10, 2017 · 3 comments · Fixed by #16066
Closed

FYI, if you build pandas release binaries with 3.6.1, they'll be broken on 3.6.0 #15961

njsmith opened this issue Apr 10, 2017 · 3 comments · Fixed by #16066
Labels
Build Library building on various platforms
Milestone
0.20.0

Comments

@njsmith
Copy link

njsmith commented Apr 10, 2017

As a heads up: https://bugs.python.org/issue29943

Two possible workarounds:

  • Make sure to use 3.6.0 if building release binaries (this way they'll work on 3.6.1 as well)
  • add a #ifdef PySlice_GetIndicesEx #undef PySlice_GetIndicesEx #endif to pandas/_libs/src/compat_helper.h (but make sure to only enable this on 3.6, or you'll eventually get broken again
@jreback
Copy link
Contributor

jreback commented Apr 10, 2017

thanks

yeah easy enough to build wheels on 3.6.0

@jreback jreback added the Build Library building on various platforms label Apr 10, 2017
@jreback jreback added this to the 0.20.0 milestone Apr 10, 2017
@jreback
Copy link
Contributor

jreback commented Apr 20, 2017

@chris-b1 you can have a look at this?

@chris-b1 chris-b1 mentioned this issue Apr 20, 2017
Merged
4 tasks
@mattip mattip mentioned this issue May 2, 2017
Closed
@mattip
Copy link
Contributor

mattip commented May 2, 2017

This broke the build for PyPy. See pull request #16192

@mattip mattip mentioned this issue May 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
0.20.0
Development

Successfully merging a pull request may close this issue.

BLD: 3.6.1 ABI compat chris-b1/pandas
3 participants
@njsmith @mattip @jreback