Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: .consolidate() should be non-public #15483

Closed
jreback opened this issue Feb 23, 2017 · 3 comments · Fixed by #15501
Closed

DEPR: .consolidate() should be non-public #15483

jreback opened this issue Feb 23, 2017 · 3 comments · Fixed by #15501
Labels
Deprecate Functionality to remove in pandas
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Feb 23, 2017

no user reason to use this, and will eventually disappear in pandas 2.0 anyhow.

I would rename to _consolidate() and then provide a deprecation warning for .consolidate(). Would need to change some internal code to use the renamed version.

xref #15482 (comment)

@jreback jreback added Deprecate Functionality to remove in pandas Difficulty Novice labels Feb 23, 2017
@jreback jreback added this to the 0.20.0 milestone Feb 23, 2017
@jreback jreback changed the title DEPR: .consolidate() this should be non-public DEPR: .consolidate() should be non-public Feb 23, 2017
@GuessWhoSamFoo
Copy link
Contributor

I'd be interested in working on this. Does renaming to _consolidate() mean that calling the method on a dataframe would be df._consolidate() ,or is there a way to change the name but still access with df.consolidate()?

@jorisvandenbossche
Copy link
Member

@GuessWhoSamFoo You can rename the existing consolidate method to _consolidate, and then create a new consolidate method that has a deprecation warning and calls the _consolidate method.

@jreback
Copy link
Contributor Author

jreback commented Feb 24, 2017

@GuessWhoSamFoo the point is that a user should never need to call .consolidate() at all, this is an internal implementation detail. We call this a little bit in the pandas implementation code, IOW, in things like core/groupby, core/generic and such. These should be changed to ._consolidate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants