Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation search broken #2743

Closed
lepture opened this issue Apr 29, 2018 · 2 comments · Fixed by pallets/pallets-sphinx-themes#3
Closed

Documentation search broken #2743

lepture opened this issue Apr 29, 2018 · 2 comments · Fixed by pallets/pallets-sphinx-themes#3
Labels
Milestone

Comments

@lepture
Copy link
Contributor

lepture commented Apr 29, 2018

How to reproduce

  1. Try search "request", it goes to this page: http://flask.pocoo.org/docs/1.0/search/?q=request
  2. Click on the result, it will be 404

The urls built on the search page are wrong, for instance:

http://flask.pocoo.org/docs/1.0/search/api/?highlight=request#flask.request

Should be

http://flask.pocoo.org/docs/1.0/api/?highlight=request#flask.request

@davidism this should be fixed in the pallets themes.

@lepture lepture added the bug label Apr 29, 2018
@davidism
Copy link
Member

This appears to be an issue with the dirhtml builder. Not sure exactly how to fix it.

@davidism
Copy link
Member

davidism commented Apr 29, 2018

This is due to sphinx-doc/sphinx#4295, which moved the documentation options from inline JS that generated the correct URL into a separate file that can't understand subdirectory pages.

I'll need to figure out how to override that, or pin at Sphinx < 1.7 until it's fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants