Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modifications to backref made inside _wrap_with_default_query_class(fn, cls) get lost #417

Closed
ekoka opened this issue Aug 19, 2016 · 1 comment · Fixed by #1087
Closed
Milestone

Comments

@ekoka
Copy link

ekoka commented Aug 19, 2016

def _wrap_with_default_query_class(fn, cls):
    @functools.wraps(fn)
    def newfn(*args, **kwargs):
        _set_default_query_class(kwargs, cls)
        if "backref" in kwargs:
            backref = kwargs['backref']
            if isinstance(backref, string_types):
                backref = (backref, {})
            _set_default_query_class(backref[1], cls)
        return fn(*args, **kwargs)
return newfn

In the code above backref is extracted from kwargs, modified if it's a string type, but the modifications are never reintroduced to kwargs.

@rsyring rsyring added this to the Unsure milestone Mar 9, 2019
@davidism davidism modified the milestones: Unsure, 3.0 Sep 18, 2022
@davidism
Copy link
Member

fixed in #1087

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants