Apache Ignite backend support #254
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh4nks
requested changes
Jun 1, 2021
flask_caching/backends/__init__.py
Outdated
| @@ -25,6 +25,7 @@ | |||
| ) | |||
| from flask_caching.backends.simplecache import SimpleCache | |||
| from flask_caching.backends.uwsgicache import UWSGICache | |||
| from flask_caching.contrib.ignitecache import IgniteCache | |||
There was a problem hiding this comment.
Don't include your backend here. This is only for officially supported backends and not for user contributed backends.
flask_caching/contrib/__init__.py
Outdated
| @@ -0,0 +1,3 @@ | |||
| from .ignitecache import IgniteCache | |||
|
|
|||
| __all__ = ['IgniteCache'] | |||
There was a problem hiding this comment.
I'd like to only use the full important path for contributed caches -- without importing the cache class here.
tests/test_init.py
Outdated
| @@ -11,6 +11,7 @@ | |||
| SASLMemcachedCache, | |||
| SimpleCache, | |||
| SpreadSASLMemcachedCache, | |||
| IgniteCache, | |||
There was a problem hiding this comment.
We don't provide tests in the official testsuite for use contributed backends.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, draft as it needs the development/next version of the Python thin-client. But comments welcomed.