Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly throw error instead of rely on NextMethod() #166

Merged
merged 3 commits into from
Dec 9, 2022
Merged

Explicitly throw error instead of rely on NextMethod() #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e26c0a4
explicitly throw error instead of rely on NextMethod()
paleolimbot Dec 9, 2022
0919b7d
fix class call
paleolimbot Dec 9, 2022
ad2eb91
NEWS
paleolimbot Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# wk (development version)

* Fix implicit reliance on error `as.data.frame.default()`,
which no longer occurs in r-devel (#166).

# wk 0.7.0

* Remove legacy headers that are no longer used by any downstream package
Expand Down
2 changes: 1 addition & 1 deletion R/wk-vctr.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ rep_len.wk_vctr <- function(x, ...) {
#' @export
as.data.frame.wk_vctr <- function(x, ..., optional = FALSE) {
if (!optional) {
NextMethod()
stop(sprintf("cannot coerce object of tyoe '%s' to data.frame", class(x)[1]))
} else {
new_data_frame(list(x))
}
Expand Down