Merge pull request #166 from paleolimbot/fix-data-frame

Explicitly throw error instead of rely on NextMethod()
paleolimbot · Dec 9, 2022 · bc75ece · bc75ece
2 parents 1b0078a + ad2eb91
commit bc75ece
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,8 @@
 # wk (development version)
 
+* Fix implicit reliance on error `as.data.frame.default()`,
+  which no longer occurs in r-devel (#166).
+
 # wk 0.7.0
 
 * Remove legacy headers that are no longer used by any downstream package

diff --git a/R/wk-vctr.R b/R/wk-vctr.R
@@ -106,7 +106,7 @@ rep_len.wk_vctr <- function(x, ...) {
 #' @export
 as.data.frame.wk_vctr <- function(x, ..., optional = FALSE) {
   if (!optional) {
-    NextMethod()
+    stop(sprintf("cannot coerce object of tyoe '%s' to data.frame", class(x)[1]))
   } else {
     new_data_frame(list(x))
   }