Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Rule suggestion: padding-line-between-statements #4435

Closed
Ivanca opened this issue Jan 3, 2019 · 4 comments
Closed

Rule suggestion: padding-line-between-statements #4435

Ivanca opened this issue Jan 3, 2019 · 4 comments

Comments

@Ivanca
Copy link

Ivanca commented Jan 3, 2019

Rule Suggestion

https://eslint.org/docs/rules/padding-line-between-statements

@Ivanca Ivanca changed the title padding-line-between-statements Rule suggestion: padding-line-between-statements Jan 3, 2019
@JoshuaKGoldberg
Copy link
Contributor

Also tracked in buzinas/tslint-eslint-rules#361.

TSLint core is somewhat moving away from these whitespace/stylistic rules (#3548) - it's unclear now whether this rule should land here or in tslint-eslint-rules.

@glen-84
Copy link
Contributor

glen-84 commented Jan 6, 2019

Not everyone wants to use Prettier, and having to pull in another dependency like tslint-eslint-rules is not always possible/ideal.

@Ivanca
Copy link
Author

Ivanca commented Jan 13, 2019

Absolutely everything in tslint/eslint is stylistic: the semicolons rules, the template strings over concatenation, etc. So singling out spacing is unexpected and weird; the one reason to use tslint/eslint is to have consistency across the code base.

@adidahiya
Copy link
Contributor

Absolutely everything in tslint/eslint is stylistic

I disagree with this; we have multiple rule categories which are not "style" or "formatting": https://palantir.github.io/tslint/rules/

As per #4534, I'm going to close this and avoid adding new code formatting rules to TSLint core. If you want to enforce this specific check with tslint, it can live happily in a custom rule set outside this repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants