Overloads signature

[AmjadHD]

@overload
def add(x: int, y:int) -> int: ...

@overload
def add(x: int, y: float) -> float: ...

def add(x, y):
    return x + y

can pyls be modified send multiple signatures in this case ?

[ccordoba12]

I don't understand what the current and expected behaviors are. Please clarify.

[joreiff]

He probably refers to https://docs.python.org/3/library/typing.html#typing.overload.

[AmjadHD]

I have three files located in one folder:
mod.py:

def add(x, y):
    return x + y

mod.pyi:

from typing import overload


@overload
def add(x: int, y: int) -> int: ...


@overload
def add(x: int, y: float) -> float: ...

and test.py:

from mod import add


add(

when I type add( in test.py with sublime text, I get this signature help:

this is sublime's LSP log:

LSP:  --> textDocument/signatureHelp
LSP:      {'activeParameter': 0, 'signatures': [{'documentation': '', 'label': 'add(x: int, y: float) -> float', 'parameters': [{'documentation': None, 'label': 'x'}, {'documentation': None, 'label': 'y'}]}], 'activeSignature': 0}

you can see that signatures contains one signature only while it should contain two as described in the LSP specification
mypy does list all overloads, maybe you can use that:

[tomv564]

The spec says:

There can be multiple signature but only one active and only one active parameter.

So it's an option, not a requirement to send multiple signatures.

Mypy is not the right tool for this, it is built for type checking entire documents, not "tell me about the thing on line 50" queries.

Jedi is the library used for signature help, and it did add support for stubs in a release last summer - I think they skipped support for overloads. See: davidhalter/jedi#839

[AmjadHD]

So it's an option, not a requirement to send multiple signatures.

yes I know it's an option this is a feature request not a bug report

Jedi is the library used for signature help, and it did add support for stubs in a release last summer - I think they skipped support for overloads. See: davidhalter/jedi#839

so should this be opened in the jedi repo ?

[ccordoba12]

Yes. This can't be solved here.