Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't use circleCI url in the "fiddle" link in autocomments #3419

Open
hellochar opened this issue Nov 8, 2017 · 0 comments
Open

don't use circleCI url in the "fiddle" link in autocomments #3419

hellochar opened this issue Nov 8, 2017 · 0 comments
Labels
Domain: Build System P3 Type: Bug

Comments

@hellochar
Copy link
Contributor

when you click "fiddle" in the autocomment bot, the resultant fiddle uses links to circle CI urls - e.g. //710-16149854-gh.circle-artifacts.com/0/home/ubuntu/plottable/plottable.js

This will fail for most users since the link requires auth into circleCI to be accessible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Domain: Build System P3 Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hellochar