Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover2 tabindex #4502

Closed
dlech opened this issue Jan 26, 2021 · 2 comments · Fixed by #4512
Closed

Popover2 tabindex #4502

dlech opened this issue Jan 26, 2021 · 2 comments · Fixed by #4512
Assignees

Comments

@dlech
Copy link
Contributor

dlech commented Jan 26, 2021

Environment

  • Package version(s): "@blueprintjs/popover2": "^0.1.1",
  • Operating System: Ubuntu 20.04
  • Browser name and version: Chromium Version 88.0.4324.96 (Official Build) snap (64-bit)

Code Sandbox

Link to a minimal repro (fork this code sandbox): https://codesandbox.io/s/blueprint-sandbox-forked-146cf?file=/src/CoreExample.tsx

The example has been modified to add Tooltip2 around the Core Sandbox buttons.

Steps to reproduce

  1. click on a blank part of the browser
  2. press tab on the keyboard to focus the buttons
  3. notice that each button is focused twice

Actual behavior

Each button is focused twice, once for the button element and once for the tooltip element.

Expected behavior

The buttons should only be focused once.

Possible solution

Don't apply tabindex to the tooltip element if child already has tabindex or make it configurable.

@adidahiya
Copy link
Contributor

Thanks for taking the new package for a spin. Good catch, I'll fix this ASAP.

@adidahiya
Copy link
Contributor

Fix open in PR #4512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants