Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headings in tooltips in dark mode are unreadable #3773

Closed
tomshen opened this issue Oct 9, 2019 · 0 comments · Fixed by #4832
Closed

Headings in tooltips in dark mode are unreadable #3773

tomshen opened this issue Oct 9, 2019 · 0 comments · Fixed by #4832
Labels
Domain: design help wanted P3 Package: core

Comments

@tomshen
Copy link
Contributor

tomshen commented Oct 9, 2019

Environment

  • Package version(s): 3.17.1
  • Browser and OS versions: MacOS 10.14.6, Chrome 77

If possible, link to a minimal repro: https://codesandbox.io/embed/blueprint-sandbox-b69x5

Steps to reproduce

  1. Add Classes.DARK to a div.
  2. Add a Tooltip as a child.
  3. Add a heading to the tooltip contents.

Actual behavior

Screen Shot 2019-10-09 at 10 53 23 AM

Expected behavior

Screen Shot 2019-10-09 at 10 55 44 AM

Possible solution

  • Dark background for tooltips
  • Special case heading colors inside tooltips
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Domain: design help wanted P3 Package: core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core,popover2] Fix heading colors in tooltips in dark mode palantir/blueprint
2 participants
@adidahiya @tomshen