Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiselect Popover with expanding input #2684

Closed
qcharlieshi opened this issue Jul 12, 2018 · 2 comments · Fixed by #2718
Closed

Multiselect Popover with expanding input #2684

qcharlieshi opened this issue Jul 12, 2018 · 2 comments · Fixed by #2718

Comments

@qcharlieshi
Copy link

qcharlieshi commented Jul 12, 2018

Environment

  • Package version(s): 3.0.0
  • Browser and OS versions: Chrome 67.0, Windows 10

Steps to reproduce

http://blueprintjs.com/docs/#select/multi-select

  1. Select many items

Actual behavior

The popover stays in place causing it to cover up the last entered tag once it falls onto multiple lines

Expected behavior

The popover should adjust (I believe it does on scroll) to stay below the input

Possible solution

The component rerenders on scroll which fixes the positioning, this could be called on adding items to the select as well. Scrolling the window by a pixel and back on popoverInteraction will make it work but is not an ideal solution.

@giladgray
Copy link
Contributor

yeah this is essentially a duplicate of #692. need to use Popper#scheduleUpdate.

@badams
Copy link
Contributor

badams commented Jul 23, 2018

@giladgray This issue wasn't in 2.3.1, at least with multi-select see the attached recordings

Blueprint 2 MultiSelect (Works as expected)
Blueprint 3 MultiSelect (Not repositioning)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants