Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests #4

Closed
ForestEckhardt opened this issue Feb 19, 2021 · 2 comments
Closed

Add integration tests #4

ForestEckhardt opened this issue Feb 19, 2021 · 2 comments

Comments

@ForestEckhardt
Copy link
Contributor

ForestEckhardt commented Feb 19, 2021

We should add integration tests that verify that rust is reliably installed onto the system.

@dmikusa
Copy link
Contributor

dmikusa commented Feb 19, 2021

I'm not sure how I feel about this one. I believe there are unit/mocks that ensure the buildpack is executing in the correct fashion and that the installer is called, as one would expect.

What the installer does though, I think we'd have to be careful to not end up with very fragile tests. I also think that if there are any integration tests, they should probably be end-to-end tests in the rust-cnb metabuildpack or even in its own repo.

I think my preference would be to keep each buildpack as light as possible and aggregate the slower integration tests elsewhere.

@ForestEckhardt
Copy link
Contributor Author

I think that we can use something the like build-plan buildpack to force detection to pass and then just run commands to see that rust available. I don't think that we need t do any more than that though.

@dmikusa dmikusa closed this as completed Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants