From 7c0f80d108f3c6dfcef05a117200c102ff6a4fa8 Mon Sep 17 00:00:00 2001 From: Anthony Dahanne Date: Mon, 13 Feb 2023 09:25:34 -0500 Subject: [PATCH 1/3] Close #996: Bump to Go 1.18 * to allow actions requiring Go 1.18 to continue building * update the documentation to indicate where to upgrade --- README.md | 8 ++++++++ actions/Dockerfile | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 88115f91..4d3376f7 100644 --- a/README.md +++ b/README.md @@ -686,6 +686,14 @@ The YourKit Dependency watches the [YourKit Download Page](https://www.yourkit.c uses: docker://ghcr.io/paketo-buildpacks/actions/yourkit-dependency:main ``` +## Updating Go version + +Dependabot could suggest to bump the Go version in some places, but you should make sure that the Go version is the same across the different tools in this repository. + +Most importantly, the Go version must be bumped in [Octo](octo/octo.go#L33) and in the [actions Dockerfile](actions/Dockerfile#L1) at the same time. + +Also, it could be a good idea to sync the go version in [the different workflows](.github/workflows). + ## License This library is released under version 2.0 of the [Apache License][a]. diff --git a/actions/Dockerfile b/actions/Dockerfile index e2345beb..8ee2eb7d 100644 --- a/actions/Dockerfile +++ b/actions/Dockerfile @@ -1,4 +1,4 @@ -FROM golang:1.17 as build-stage +FROM golang:1.18 as build-stage RUN apt-get update && apt-get install -y --no-install-recommends upx From df1d49b5da2ff809f3a304f5c239088715d1c468 Mon Sep 17 00:00:00 2001 From: Anthony Dahanne Date: Tue, 14 Feb 2023 09:06:25 -0500 Subject: [PATCH 2/3] Update README.md rephrase when to update Co-authored-by: Daniel Mikusa --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 4d3376f7..d93e6e11 100644 --- a/README.md +++ b/README.md @@ -688,7 +688,7 @@ uses: docker://ghcr.io/paketo-buildpacks/actions/yourkit-dependency:main ## Updating Go version -Dependabot could suggest to bump the Go version in some places, but you should make sure that the Go version is the same across the different tools in this repository. +When it is time to update the Go version in the project, you should make sure that the Go version is the same across the different tools in this repository. Most importantly, the Go version must be bumped in [Octo](octo/octo.go#L33) and in the [actions Dockerfile](actions/Dockerfile#L1) at the same time. From 3a92bf956d7c260e9d4ad93fadc64c74047010ba Mon Sep 17 00:00:00 2001 From: Anthony Dahanne Date: Tue, 14 Feb 2023 09:07:00 -0500 Subject: [PATCH 3/3] Update README.md * add info about octo version update Co-authored-by: Daniel Mikusa --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index d93e6e11..80e24291 100644 --- a/README.md +++ b/README.md @@ -692,7 +692,7 @@ When it is time to update the Go version in the project, you should make sure th Most importantly, the Go version must be bumped in [Octo](octo/octo.go#L33) and in the [actions Dockerfile](actions/Dockerfile#L1) at the same time. -Also, it could be a good idea to sync the go version in [the different workflows](.github/workflows). +The Go version is also in [the different workflows](.github/workflows), however, this will be updated automatically by `octo`. You can run `octo` locally or submit a PR, and when the PR is merged CI will run `octo` and in turn submit another PR that updates the Go version. ## License This library is released under version 2.0 of the [Apache License][a].