Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default instead of override for Gem path env var. #524

Merged
merged 1 commit into from
May 2, 2023
Merged

Use default instead of override for Gem path env var. #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ func Build(
return packit.BuildResult{}, err
}

mriLayer.SharedEnv.Override("GEM_PATH", strings.TrimSpace(buffer.String()))
mriLayer.SharedEnv.Default("GEM_PATH", strings.TrimSpace(buffer.String()))
mriLayer.SharedEnv.Default("MALLOC_ARENA_MAX", "2")

logger.EnvironmentVariables(mriLayer)
Expand Down
2 changes: 1 addition & 1 deletion build_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ func testBuild(t *testing.T, context spec.G, it spec.S) {

Expect(layer.SharedEnv).To(Equal(packit.Environment{
"MALLOC_ARENA_MAX.default": "2",
"GEM_PATH.override": "/some/mri/gems/path",
"GEM_PATH.default": "/some/mri/gems/path",
}))
Expect(layer.BuildEnv).To(BeEmpty())
Expect(layer.LaunchEnv).To(BeEmpty())
Expand Down