-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable detect to support multiple jar files #132
Comments
it's a duplicate of #206 , right? should we close it? |
I don't think they are duplicates. #206 is a problem that occurs when you have an intended executable JAR but then one of the dependencies of that executable JAR is also executable. The buildpack may sometimes select the wrong JAR to execute. There's no way to tell the buildpack to pick a particular JAR, so that issue is to add a way to select the specific JAR to execute. Presently, you can only hit the previous issue if you build from source. This one is to change detect so that you could build source code locally and package an image from say a directory of JAR files you built. There's probably not a huge need for this issue, #206 is definitely more important. |
But that is not true, right? I see it as a bug in the detect logic. This is fixed by #265. |
I'm trying to understand what's left of this issue after #265 was merged. From what I understood users can already provide |
If @anthonydahanne If that's the anticipated behavior, we can close this issue. However, I'd expect that |
What happened?
The executable jar buildpack will detect if you either:
In some cases, you may want to compile locally but build an image from a directory or archive that is not an executable JAR. This is not presently possible because detect.go looks for
/workspace/META-INF/MANIFEST.MF
, which will only exist if the asset being provided to build is an executable JAR.This enhancement request is to have detect also look at the present workspace and see if either a.) the workspace itself has a manifest or if b.) it can identify a single executable JAR file in the workspace.
The text was updated successfully, but these errors were encountered: