Should allow non-zero exit code when generating graph

[f4irline]

I have a use case where I'm running madge in CI to check for circular dependencies. I just noticed that if you generate the dependency graph when checking for circular dependencies, madge returns exit code 0 even if there are circular dependencies. Probably because generating the image graph returns exit code 0 when the graph is generated successfully, and 1 if generating the image fails?

Could we add a flag or something to the CLI to make madge optionally exit with non-zero exit code even when generating the graph, if circular dependencies are found?

[f4irline]

I have a use case where I'm running madge in CI to check for circular dependencies. I just noticed that if you generate the dependency graph when checking for circular dependencies, madge returns exit code 0 even if there are circular dependencies. Probably because generating the image graph returns exit code 0 when the graph is generated successfully, and 1 if generating the image fails?

Could we add a flag or something to the CLI to make madge optionally exit with non-zero exit code even when generating the graph, if circular dependencies are found?

I'm also happy to contribute and see if I'm able to implement the flag, if this sounds reasonable 🙂

[Smrtnyk]

you can do it also yourself

(async () => {
    const deps = await madge("<some-path>", CONFIG).then((res) => res.circular());
    console.log(`Detected ${deps.length} circular deps.`);
    console.log(util.inspect(deps.map(formatCircularItem)));
    if (deps.length > ALLOWED_CIRCULAR_DEPS) {
        console.error("Detected more circular deps than allowed. Exiting process.");
        process.exit(1);
    }
})();

[PabloLION]

I'm also happy to contribute and see if I'm able to implement the flag, if this sounds reasonable

It does sound reasonable to me. PRs are welcomed and appreciated