feat: Poc requirements #1
Conversation
added postman collections
| */ | ||
| @HeaderParam("id") | ||
| @NotNull(message = "[" + ErrorCode.SESSION_ID_MUST_NOT_BE_NULL + "] SessionId must not be null") | ||
| @Pattern(regexp = "^[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}$", message = "[" + ErrorCode.SESSION_ID_MUST_MATCH_REGEXP + "] RequestId must match \"{regexp}\"") |
There was a problem hiding this comment.
Attenzione al messaggio: c'è scritto 'RequestId' ma lo header param si chiama 'id'.
| * Session ID | ||
| */ | ||
| @HeaderParam("id") | ||
| @NotNull(message = "[" + ErrorCode.SESSION_ID_MUST_NOT_BE_NULL + "] SessionId must not be null") |
There was a problem hiding this comment.
Attenzione al messaggio: c'è scritto 'SessionId' ma lo header param si chiama 'id'.
| public String toString() { | ||
| StringBuilder builder = new StringBuilder(); | ||
| builder.append("PmWalletCardsRequest [taxCode="); | ||
| builder.append(taxCode); |
There was a problem hiding this comment.
'taxCode' è un dato sensibile, metterlo nel toString comporta il suo logging accidentale: rimuoverlo o sostituirlo con ***.
| builder.append("SessionResponse [outcome="); | ||
| builder.append(outcome); | ||
| builder.append(", taxCode="); | ||
| builder.append(taxCode); |
There was a problem hiding this comment.
'taxCode' è un dato sensibile, metterlo nel toString comporta il suo logging accidentale: rimuoverlo o sostituirlo con ***.
| return sessionService.getSessionById(headers.getSessionId(), headers).onFailure() | ||
| .transform(f -> { | ||
| if (f instanceof ClientWebApplicationException c) { | ||
| Log.errorf(f, "[%s] Error while retrieving session. Http Status code [%s] " , ErrorCode.ERROR_SESSION_NOT_FOUND_SERVICE,c.getResponse().getStatus()) ; |
There was a problem hiding this comment.
ERROR_SESSION_NOT_FOUND_SERVICE -> SESSION_NOT_FOUND_ERROR
| }) | ||
| .chain (s -> { | ||
| if (Outcome.TERMS_AND_CONDITIONS_NOT_YET_ACCEPTED.toString().equals(s.getOutcome())) { | ||
| Log.errorf("[%s] The terms and conditions are not yet accepted ", ErrorCode.ERROR_TC_NOT_YET_ACCEPTED); |
There was a problem hiding this comment.
ERROR_TC_NOT_YET_ACCEPTED -> TC_NOT_YET_ACCEPTED_ERROR
|
|
||
| } else { | ||
| if (Boolean.FALSE.equals(s.getSaveNewCards())) { | ||
| Log.errorf("[%s] Save cards is not active ", ErrorCode.ERROR_SAVE_CARD_NOT_ACTIVE); |
There was a problem hiding this comment.
ERROR_SAVE_CARD_NOT_ACTIVE -> SAVE_CARD_NOT_ACTIVE_ERROR
| if (f.getStatus() != Status.NO_CONTENT.getStatusCode()) { | ||
| return Response | ||
| .status(Status.INTERNAL_SERVER_ERROR) | ||
| .entity(new Errors(List.of(ErrorCode.ERROR_GENERIC_CALLING_PM_WALLET_SERVICE))) |
There was a problem hiding this comment.
ERROR_GENERIC_CALLING_PM_WALLET_SERVICE -> GENERIC_ERROR_CALLING_PM_WALLET_SERVICE
obfuscated taxCode fix message names
PSCF2-86 Migrazione package mil-wallet
|
SonarCloud Quality Gate failed.
|
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.