This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
[#IOPID-148] update LC middleware with multiple encoding verification #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOPID-148 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #38 +/- ##
==========================================
+ Coverage 86.38% 87.17% +0.79%
==========================================
Files 23 22 -1
Lines 727 725 -2
Branches 64 63 -1
==========================================
+ Hits 628 632 +4
+ Misses 95 89 -6
Partials 4 4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
fabriziopapi
approved these changes
Apr 18, 2023
Comment on lines
+154
to
172
| TE.map( | ||
| key => | ||
| [ | ||
| request, | ||
| lollipopHeaders["x-pagopa-lollipop-assertion-ref"], | ||
| key, | ||
| rawBody | ||
| ] as const | ||
| ), | ||
| TE.chain(params => | ||
| // IO app is currently signing using 'der' algorithm only. | ||
| // Anyway, a LC should be ready to verify 'ieee-p1363' algorithm too. | ||
| pipe( | ||
| validateHttpSignatureWithEconding("der")(...params), | ||
| TE.orElse(() => | ||
| validateHttpSignatureWithEconding("ieee-p1363")(...params) | ||
| ) | ||
| ) | ||
| ), |
There was a problem hiding this comment.
Maybe we could refactor the validateHttpSignatureWithEconding to use a type as input to avoid the ...params array decostruction.
sabontech
added a commit
to pagopa/io-app
that referenced
this pull request
Apr 21, 2023
##⚠️ Depends on pagopa-archive/io-functions-lollipop#38, pagopa/io-backend#1006, pagopa/io-dev-api-server#233⚠️ ## ## Short description This PR add a Lollipop Playground page to call the first LC for debugging purpose. ## List of changes proposed in this pull request - [package.json](https://github.com/pagopa/io-app/pull/4545/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519): add OpenApi specs and client generation. - [ts/features/lollipop/api/backend.ts](https://github.com/pagopa/io-app/pull/4545/files#diff-f74e1d5ec082224b0319d628738f4276acd718325ec8adf1b024edcf831d054a): Adds the lollipop backend server. - [ts/features/lollipop/playgrounds/LollipopPlaygroundContent.tsx](https://github.com/pagopa/io-app/pull/4545/files#diff-d1d3dd0d4f65dbaffcc58b5b41f71abc080812ff110a7195addc8c960392163b): - [ts/features/lollipop/playgrounds/LollipopPlayground.tsx](https://github.com/pagopa/io-app/pull/4545/files#diff-7177b8ec63fef44a3ace9d084515adeefd1a8979d89f9cc3030989173797799d): Adds the lollipop Playground Screen. - [ts/navigation/ProfileNavigator.tsx](https://github.com/pagopa/io-app/pull/4545/files#diff-fde597880587bbd6b7df5084df5a2bb4020db9a4d14f00b29967f3faf58ad7a1): - [ts/navigation/params/ProfileParamsList.ts](https://github.com/pagopa/io-app/pull/4545/files#diff-f3f50220ac440ed85361a813ef5aff2d66dc324b38c8d47f9de541651342fb41): - [ts/navigation/routes.ts](https://github.com/pagopa/io-app/pull/4545/files#diff-950467b6141738ddf5a35aa966af7ea9731f4f70825f4fcf2e3d62f33f7ac547): - [ts/screens/profile/ProfileMainScreen.tsx](https://github.com/pagopa/io-app/pull/4545/files#diff-de3c1a64bcc8fdca4c8dbc5d62dba36c8c5ded27255052ecc6526e614b1e8f5b): Manages the navigation to the lollipop playground from the profile page in debug mode. ## How to test Run the app and go to the new lollipop playground screen. Write something in the text field and tap "Sign". You should see a "success" alert showing the current server assertion ref. Test it by pointing to production and also by using the dev server. --------- Co-authored-by: SabPicariello <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Updated
customVerifywith encodingUpdated default check with
derencoding, into LC middleware and added fallback check withieee-p1363encoding.Motivation and Context
Fix e2e signature verification + enable signature verification with multiple encoding.
How Has This Been Tested?
Unit tests
Screenshots (if appropriate):
Types of changes
Checklist: