-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [IOBP-1020] Using optimistic UI for remove payment method action #6446
chore: [IOBP-1020] Using optimistic UI for remove payment method action #6446
Conversation
…ayment-method-action
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6446 +/- ##
==========================================
- Coverage 48.42% 48.41% -0.01%
==========================================
Files 1488 1577 +89
Lines 31617 32183 +566
Branches 7669 7331 -338
==========================================
+ Hits 15311 15583 +272
- Misses 16238 16547 +309
+ Partials 68 53 -15
... and 1712 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…ayment-method-action
…ayment-method-action
…ayment-method-action
…ayment-method-action
…ayment-method-action
…ayment-method-action
…ayment-method-action
…ayment-method-action
…ayment-method-action
…ayment-method-action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Tested on iOS simulator and Android emulator with different cases and it works as expected ✨
LGTM!
…ayment-method-action
…ayment-method-action
Short description
This pull request introduces several changes to include an optimistic UI logic for the handling of deleted wallet cards in the wallet management system
List of changes proposed in this pull request
DeletedCard
type and updated theWalletCardsState
type to include an optionaldeletedCard
property.paymentsDeleteMethodAction
request, cancel, and failure actions, ensuring that deleted cards can be restored if necessary.selectWalletCards
selector to exclude thedeletedCard
from the list of wallet cards.walletRemoveCards
and added logic to dispatch a failure action with network error details if the deletion failsHow to test
addPaymentWalletHandler
delete function with 400 response)Preview
Screen.Recording.2024-11-22.at.10.25.31.mov