feat(Bonus Pagamenti Digitali): [#176578587] Cobadge detail screen #2751
Conversation
debiff
requested review from
CrisTofani,
fabriziofff and
Undermaken
as code owners
pagopa-github-bot
changed the title
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2751 +/- ##
==========================================
+ Coverage 53.86% 53.91% +0.05%
==========================================
Files 793 794 +1
Lines 21942 21996 +54
Branches 4142 4150 +8
==========================================
+ Hits 11818 11860 +42
- Misses 10068 10080 +12
Partials 56 56
Continue to review full report at Codecov.
|
…nstead of create a new one
…578-cobadge-preview-card
…578-cobadge-preview-card
…8587-cobadge-detail-screen
| width: 80, | ||
| height: 40, | ||
| resizeMode: "contain" |
There was a problem hiding this comment.
| width: 80, | |
| height: 40, | |
| resizeMode: "contain" | |
| width: 48, | |
| height: 30, | |
| resizeMode: "contain" |
Changed following the Invision specs:
There was a problem hiding this comment.
Modified dimensions accordingly to the InVision specs in 8e95104
| {props.abiLogo && imageStyle ? ( | ||
| <Image | ||
| source={{ uri: props.abiLogo }} | ||
| style={imageStyle} | ||
| testID={"abiLogo"} | ||
| /> | ||
| ) : ( | ||
| <Image | ||
| source={abiLogoFallback} | ||
| style={styles.abiLogoFallback} | ||
| testID={"abiLogoFallback"} | ||
| /> |
There was a problem hiding this comment.
On iOS I always see the fallback image.
Registrazione.schermo.2021-01-29.alle.18.32.16.mov
| {props.abiLogo && imageStyle ? ( | |
| <Image | |
| source={{ uri: props.abiLogo }} | |
| style={imageStyle} | |
| testID={"abiLogo"} | |
| /> | |
| ) : ( | |
| <Image | |
| source={abiLogoFallback} | |
| style={styles.abiLogoFallback} | |
| testID={"abiLogoFallback"} | |
| /> | |
| {props.abiLogo && imageStyle ? ( | |
| <Image | |
| source={{ uri: props.abiLogo }} | |
| style={imageStyle} | |
| testID={"abiLogo"} | |
| key={"abiLogo"} | |
| /> | |
| ) : ( | |
| <Image | |
| source={abiLogoFallback} | |
| style={styles.abiLogoFallback} | |
| testID={"abiLogoFallback"} | |
| key={"abiLogoFallback"} | |
| /> |
My guess is that the node occupies the same position and the cache is not refreshered, obtaining something similar to facebook/react-native#9195.
Using different keys it renders correctly for me both on iOS and Android.
There was a problem hiding this comment.
Thanks for the suggestion. Working always on the same card I never notice this bug.
Fixed in a6c4e84
| image={getCardIconFromBrandLogo(props.cobadge.info)} | ||
| onPress={() => props.navigateToCobadgeDetails(props.cobadge)} | ||
| image={brandLogo} | ||
| onPress={() => props.navigateToCobadgeDetails(props.cobadge, brandLogo)} |
There was a problem hiding this comment.
What you think about passing only props.cobadge as navigation param? The brandlogo can always be uniquely derived using getCardIconFromBrandLogo.
There was a problem hiding this comment.
Yes, sure.
Modified in 0816b1d
| const aBrandLogo = defaultCardIcon; | ||
| const anExpireMonth = "6"; | ||
| const anExpireYear = "2021"; | ||
| describe("BPayWalletPreview component", () => { |
There was a problem hiding this comment.
| describe("BPayWalletPreview component", () => { | |
| describe("CoBadgeWalletPreview component", () => { |
This PR depends on #2746
Short description
This PR add the detail of a Cobadge credit card
List of changes proposed in this pull request