Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): use cache to check if public key exists #902

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

b00f
Copy link
Collaborator

@b00f b00f commented Jan 3, 2024

Description

This PR uses a cache to check if a public key exists or not. If not, it looks up the DB.
It also defines a new error for invalid config data.

@b00f b00f requested a review from amirvalhalla January 3, 2024 12:38
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Merging #902 (157c8a4) into main (38372dd) will decrease coverage by 0.07%.
The diff coverage is 82.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #902      +/-   ##
==========================================
- Coverage   83.50%   83.44%   -0.07%     
==========================================
  Files         173      173              
  Lines        8774     8787      +13     
==========================================
+ Hits         7327     7332       +5     
- Misses       1097     1105       +8     
  Partials      350      350              

@amirvalhalla amirvalhalla merged commit ea1ca66 into pactus-project:main Jan 3, 2024
12 checks passed
@b00f b00f deleted the pub-key-cache branch January 11, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants