Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(executor): not rejecting bond transaction for bootstrap validator #901

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

b00f
Copy link
Collaborator

@b00f b00f commented Jan 3, 2024

Description

This PR reverts PR #870 and fixes issue #900.

Related issue(s)

@b00f b00f requested review from Ja7ad, kehiy and amirvalhalla January 3, 2024 06:07
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Merging #901 (b4cb623) into main (72d58bc) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #901      +/-   ##
==========================================
- Coverage   83.53%   83.46%   -0.07%     
==========================================
  Files         173      173              
  Lines        8774     8774              
==========================================
- Hits         7329     7323       -6     
- Misses       1096     1100       +4     
- Partials      349      351       +2     

sandbox/mock.go Show resolved Hide resolved
@b00f b00f changed the title fix(executor): no rejecting bond transaction for bootstrap validator fix(executor): not rejecting bond transaction for bootstrap validator Jan 3, 2024
Copy link
Contributor

@kehiy kehiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good.

@kehiy kehiy merged commit 38372dd into pactus-project:main Jan 3, 2024
13 checks passed
@b00f b00f deleted the fixing-900 branch January 6, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to sync the blockchain
2 participants