Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing BasicCheck for hash #845

Merged
merged 2 commits into from
Dec 10, 2023

Conversation

b00f
Copy link
Collaborator

@b00f b00f commented Dec 10, 2023

Description

This PR removes BasicCheck method from the hash.

Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Merging #845 (8393207) into main (fac0ef3) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #845      +/-   ##
==========================================
- Coverage   83.14%   83.14%   -0.01%     
==========================================
  Files         170      170              
  Lines        8573     8567       -6     
==========================================
- Hits         7128     7123       -5     
+ Misses       1104     1103       -1     
  Partials      341      341              

Copy link
Member

@amirvalhalla amirvalhalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b00f thanks.

@amirvalhalla amirvalhalla merged commit 75c1cc0 into pactus-project:main Dec 10, 2023
12 checks passed
@b00f b00f deleted the removing-hash-basic-check branch December 11, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants