Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: subscribing to libp2p eventbus #831

Merged
merged 8 commits into from
Dec 1, 2023

Conversation

b00f
Copy link
Collaborator

@b00f b00f commented Dec 1, 2023

Description

By subscribing to the libp2p event bus, we can receive notifications when the node's reachability and supported protocols change.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #831 (f5190bd) into main (d79fe60) will increase coverage by 0.28%.
The diff coverage is 90.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #831      +/-   ##
==========================================
+ Coverage   82.72%   83.01%   +0.28%     
==========================================
  Files         172      170       -2     
  Lines        8400     8454      +54     
==========================================
+ Hits         6949     7018      +69     
+ Misses       1121     1112       -9     
+ Partials      330      324       -6     

network/notifee.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kehiy kehiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@kehiy kehiy merged commit e21352d into pactus-project:main Dec 1, 2023
12 checks passed
@b00f b00f deleted the libp2p-eventbus branch December 2, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants