Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: data race issue on updating certificate #747

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

b00f
Copy link
Collaborator

@b00f b00f commented Oct 13, 2023

Description

A data race issue could occur when updating the certificate, as we can see here in this action. This PR deeply clones the certificate to prevent it.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #747 (159348a) into main (a838ea1) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
+ Coverage   82.76%   82.88%   +0.11%     
==========================================
  Files         173      173              
  Lines        8044     8047       +3     
==========================================
+ Hits         6658     6670      +12     
+ Misses       1065     1058       -7     
+ Partials      321      319       -2     

@amirvalhalla amirvalhalla self-requested a review October 13, 2023 12:45
@amirvalhalla amirvalhalla merged commit 65d0f18 into pactus-project:main Oct 13, 2023
12 checks passed
@b00f b00f deleted the fixing-data-race-issue branch January 11, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants