Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implementing pip-8 #711

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Conversation

amirvalhalla
Copy link
Member

Description

This PR implemented pip-8

It also fixes #510

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #711 (5e9e5e6) into main (7c14d41) will decrease coverage by 0.24%.
The diff coverage is 79.81%.

@@            Coverage Diff             @@
##             main     #711      +/-   ##
==========================================
- Coverage   83.38%   83.14%   -0.24%     
==========================================
  Files         168      171       +3     
  Lines        7825     7940     +115     
==========================================
+ Hits         6525     6602      +77     
- Misses       1004     1027      +23     
- Partials      296      311      +15     

Copy link
Collaborator

@b00f b00f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amirvalhalla

Thanks. An important and crucial PR.

crypto/bls/public_key.go Show resolved Hide resolved
crypto/crypto.go Outdated Show resolved Hide resolved
crypto/signer.go Outdated Show resolved Hide resolved
execution/execution_test.go Outdated Show resolved Hide resolved
execution/execution_test.go Outdated Show resolved Hide resolved
sync/handler_blocks_response_test.go Outdated Show resolved Hide resolved
sync/handler_blocks_response_test.go Outdated Show resolved Hide resolved
sync/sync.go Outdated Show resolved Hide resolved
types/proposal/proposal_test.go Outdated Show resolved Hide resolved
wallet/addresspath/path.go Outdated Show resolved Hide resolved
@amirvalhalla amirvalhalla merged commit a8d5a56 into pactus-project:main Sep 27, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn Users When Attempting to Bond to a Reward Address
3 participants