Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: supporting go version 1.21 and higher #692

Merged
merged 9 commits into from
Sep 13, 2023

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Sep 12, 2023

Description

Related issue(s)

If this Pull Request is related to an issue, mention it here.

@b00f
Copy link
Collaborator

b00f commented Sep 13, 2023

@kehiy fix the errors

@kehiy
Copy link
Contributor Author

kehiy commented Sep 13, 2023

@b00f all of them is done
there is just some small issue in network test

@b00f
Copy link
Collaborator

b00f commented Sep 13, 2023

It says:

"github.com/libp2p/go-libp2p/p2p/host/resource-manager/obs" is deprecated: obs is deprecated and the exported types and methods are moved to rcmgr package

Try to change obs to rcmgr

@kehiy
Copy link
Contributor Author

kehiy commented Sep 13, 2023

@b00f the linter issue is okay, it was fixed before.
we have an issue in the network test.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #692 (4910bbb) into main (b56af2f) will not change coverage.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage   83.48%   83.48%           
=======================================
  Files         168      168           
  Lines        7969     7969           
=======================================
  Hits         6653     6653           
  Misses       1012     1012           
  Partials      304      304           

@b00f b00f merged commit 3557f88 into pactus-project:main Sep 13, 2023
12 checks passed
@kehiy kehiy deleted the hotfix/goVersion branch September 13, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

supporting v1.21.0
2 participants