Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding udp protocol for network #672

Merged
merged 12 commits into from
Sep 2, 2023
Merged

feat: adding udp protocol for network #672

merged 12 commits into from
Sep 2, 2023

Conversation

b00f
Copy link
Collaborator

@b00f b00f commented Sep 1, 2023

Description

This PR adds a tests to make sure UDP and IPv6 protocols are supported in the network module.

Related issue(s)

Maybe related to #620

@codecov
Copy link

codecov bot commented Sep 1, 2023 •
edited
Loading

Codecov Report

Merging #672 (3da3f00) into main (5ec7759) will decrease coverage by 0.06%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
- Coverage   83.76%   83.70%   -0.06%     
==========================================
  Files         166      167       +1     
  Lines        8005     8008       +3     
==========================================
- Hits         6705     6703       -2     
- Misses        997     1002       +5     
  Partials      303      303

kehiy
kehiy approved these changes Sep 2, 2023
View reviewed changes
Copy link
Contributor

@kehiy kehiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good.

amirvalhalla
amirvalhalla reviewed Sep 2, 2023
View reviewed changes
network/errors.go Outdated Show resolved Hide resolved
amirvalhalla
amirvalhalla reviewed Sep 2, 2023
View reviewed changes
network/errors.go Outdated Show resolved Hide resolved
ZigBalthazar
ZigBalthazar approved these changes Sep 2, 2023
View reviewed changes
Copy link
Contributor

@ZigBalthazar ZigBalthazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amirvalhalla
amirvalhalla requested changes Sep 2, 2023
View reviewed changes
Copy link
Member

@amirvalhalla amirvalhalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b00f
please resolve request changes.

@amirvalhalla
Copy link
Member

@b00f
Thanks.

@kehiy kehiy merged commit 85f3063 into pactus-project:main Sep 2, 2023
11 of 12 checks passed
@b00f b00f deleted the netowrk-test-udp branch January 11, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirvalhalla amirvalhalla amirvalhalla approved these changes

@kehiy kehiy kehiy approved these changes

@ZigBalthazar ZigBalthazar ZigBalthazar approved these changes

@yenkhoon yenkhoon Awaiting requested review from yenkhoon

@Ja7ad Ja7ad Awaiting requested review from Ja7ad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@b00f @amirvalhalla @ZigBalthazar @kehiy