Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error case for logger #634

Merged
merged 1 commit into from
Aug 13, 2023
Merged

fix: error case for logger #634

merged 1 commit into from
Aug 13, 2023

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Aug 13, 2023

If a field in the log is an error, the error message will be printed.

@kehiy kehiy marked this pull request as ready for review August 13, 2023 17:24
@kehiy kehiy requested a review from b00f August 13, 2023 17:24
@kehiy kehiy enabled auto-merge (squash) August 13, 2023 17:24
@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Merging #634 (4dda6dd) into main (1e75928) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #634   +/-   ##
=======================================
  Coverage   83.62%   83.63%           
=======================================
  Files         155      155           
  Lines        7286     7288    +2     
=======================================
+ Hits         6093     6095    +2     
  Misses        914      914           
  Partials      279      279           

@kehiy kehiy merged commit d9c575d into pactus-project:main Aug 13, 2023
@kehiy kehiy deleted the hotfix/log branch August 16, 2023 17:20
@themantre themantre changed the title fix: error case fix: error case for logger Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants