fix: measuring total sent and received bytes #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #552 +/- ##
==========================================
+ Coverage 83.28% 83.38% +0.09%
==========================================
Files 154 154
Lines 7341 7420 +79
==========================================
+ Hits 6114 6187 +73
- Misses 947 952 +5
- Partials 280 281 +1 |
b00f
requested review from
vlasfama,
yenkhoon,
Ja7ad and
a team
and removed request for
a team
Ja7ad
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we measure the total bytes sent and received by the node within the sync package.
This might address issue #529, but we still need more information.
For instance, we could measure the total stream and gossip messages.
We could even categorize the measurements by message type.
Related issue(s)
It's related to #529