fix(consensus): rejecting vote with round numbers exceeding the limit #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #466 +/- ##
=======================================
Coverage 82.45% 82.46%
=======================================
Files 149 149
Lines 7004 7007 +3
=======================================
+ Hits 5775 5778 +3
Misses 938 938
Partials 291 291 |
themantre
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds a check to ensure that votes with round numbers more than two rounds larger than the current round are rejected. This prevents byzantine validators from causing network crashes by broadcasting votes with large round numbers.
Related issue(s)
Fixing #465