feat(grpc): add bls public key and signature aggregate methods #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1587 +/- ##
==========================================
+ Coverage 75.07% 75.94% +0.87%
==========================================
Files 234 236 +2
Lines 12156 18228 +6072
==========================================
+ Hits 9126 13844 +4718
- Misses 2582 3921 +1339
- Partials 448 463 +15 |
Ja7ad
approved these changes
Nov 7, 2024
Ja7ad
reviewed
Nov 7, 2024
|
@alidevjimmy please add grpc-gateway method |
…vjimmy/pactus into feat/grpc-sig-and-pubkey-aggregate
|
@Ja7ad Please check PR again. |
Ja7ad
approved these changes
Nov 8, 2024
|
@alidevjimmy Well done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
BLSPublicKeyAggregationandBLSSignatureAggregationmethods to gRPC API.Related issue(s)