fix(grpc): get tx pool content filter by payload type #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1581 +/- ##
==========================================
+ Coverage 75.07% 75.88% +0.81%
==========================================
Files 234 236 +2
Lines 12156 18199 +6043
==========================================
+ Hits 9126 13811 +4685
- Misses 2582 3925 +1343
- Partials 448 463 +15 |
Ja7ad
approved these changes
Nov 3, 2024
|
@alidevjimmy If PR have exists issue, please mention it. |
b00f
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
GetTxPoolContentmethod filter bypayload type.UNKNOWNtype returns all pending transactions in tx poolRelated issue(s)
Fixes #1571