fix(gtk): width size of listbox and download button #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b00f
reviewed
Jul 25, 2024
|
|
||
| ssDLBtn, err := gtk.ButtonNewWithLabel("⏬ Download") | ||
| fatalErrorCheck(err) | ||
| setMargin(ssDLBtn, 10, 5, 1, 1) | ||
| ssDLBtn.SetHAlign(gtk.ALIGN_CENTER) | ||
| ssDLBtn.SetSizeRequest(600, -1) | ||
| ssDLBtn.SetSizeRequest(700, -1) |
There was a problem hiding this comment.
What happens if we don't set size?
There was a problem hiding this comment.
What happens if we don't set size?
Make smaller size as default, gtk don't support auto size as percent.
|
@Ja7ad fix PR's title. |
b00f
changed the title
b00f
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fix width of list box items in prune node and download button.