Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store): prune block function #1399

Merged
merged 4 commits into from
Jul 8, 2024
Merged

feat(store): prune block function #1399

merged 4 commits into from
Jul 8, 2024

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Jul 8, 2024

Description

This PR implements the prune block function defined on PIP-27.

Related issue

@kehiy kehiy requested review from b00f, Ja7ad and akbariandev July 8, 2024 09:53
Ja7ad
Ja7ad requested changes Jul 8, 2024
View reviewed changes
store/store.go Outdated Show resolved Hide resolved
b00f
b00f requested changes Jul 8, 2024
View reviewed changes
store/store.go Outdated Show resolved Hide resolved
store/store.go Show resolved Hide resolved
Ja7ad
Ja7ad requested changes Jul 8, 2024
View reviewed changes
store/store.go Show resolved Hide resolved
b00f
b00f requested changes Jul 8, 2024
View reviewed changes
store/store.go Show resolved Hide resolved
@Ja7ad
Copy link
Contributor

Ja7ad commented Jul 8, 2024 •
edited
Loading

@b00f For prune command in task #1392 we need to get public method to prune 1 block with transactions while pruning.

@kehiy kehiy requested a review from b00f July 8, 2024 13:01
@b00f
Copy link
Collaborator

b00f commented Jul 8, 2024 •
edited
Loading

@b00f For prune command in task #1392 we need to get public method to prune 1 block with transactions while pruning.

the pruneBlock is private: https://pips.pactus.org/PIPs/pip-27

image

@b00f b00f merged commit 5fc8261 into pactus-project:main Jul 8, 2024
10 checks passed
@kehiy kehiy deleted the feature/prune branch July 8, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ja7ad Ja7ad Ja7ad requested changes

@b00f b00f b00f approved these changes

@akbariandev akbariandev Awaiting requested review from akbariandev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PruneBlock function
3 participants
@kehiy @Ja7ad @b00f