-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pip): implement PIP-23 #1397
Conversation
ZigBalthazar
commented
Jul 4, 2024
•
edited by kehiy
Loading
edited by kehiy
- Fixes PIP-23: Sign and verify message by public and private key account #1386
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run make proto
and make sure it finishes properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write utils service (utils.proto
) for sign and verify message outside of wallet.
http: |
- selector: pactus.Utils.SignMessage
get: "/pactus/utils/sign_message"
- selector: pactus.Utils.VerifyMessage
get: "/pactus/utils/verify_message"
Hi @Ja7ad , |
You should do it, it don't have vulnerability. |
e585329
to
8ae5f1e
Compare
6398ca8
to
a5486cb
Compare
048c4f4
to
866c8ea
Compare
fd43cfc
to
3d7f3bf
Compare
a0724b9
to
99d2dc4
Compare
18c724a
to
f87e3df
Compare
2ac7a90
to
8099697
Compare
@ZigBalthazar please register utils service in json-rpc server. https://github.com/pactus-project/pactus/blob/main/www%2Fjsonrpc%2Fserver.go#L57-L60 Also for grpc gateway too: https://github.com/pactus-project/pactus/blob/main/www%2Fgrpc%2Fgateway.go#L55-L67 |
44afdea
to
c396095
Compare
@ZigBalthazar Please generate proto for new changes. |
@ZigBalthazar Thanks |
@ZigBalthazar Please regenerate proto. |
e6b65bb
to
94c310c
Compare