From 0b41f6e89f8af52275a41b8cd338836c549af91f Mon Sep 17 00:00:00 2001 From: mantre Date: Mon, 4 Mar 2024 19:50:45 +0800 Subject: [PATCH 1/2] fix: save Mainnet config with inline comments --- cmd/cmd.go | 4 ++-- config/example_config.toml | 6 ++++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/cmd/cmd.go b/cmd/cmd.go index fd04d506b..02362d5d3 100644 --- a/cmd/cmd.go +++ b/cmd/cmd.go @@ -314,8 +314,8 @@ func CreateNode(numValidators int, chain genesis.ChainType, workingDir string, if err := genDoc.SaveToFile(genPath); err != nil { return nil, nil, err } - conf := config.DefaultConfigMainnet() - if err := conf.Save(confPath); err != nil { + err := config.SaveMainnetConfig(confPath) + if err != nil { return nil, nil, err } case genesis.Testnet: diff --git a/config/example_config.toml b/config/example_config.toml index a80d89e8a..8ee410a41 100644 --- a/config/example_config.toml +++ b/config/example_config.toml @@ -80,7 +80,9 @@ # `moniker` is a custom human-readable name for this node. ## moniker = "" - # `session_timeout` is a timeout for a session to be opened. + # `session_timeout` is a timeout for a download session to keep open. + # By sending a block download request, this timer starts and if there is no activity from the Node + # the session will get closed and try to get the block from another Node. # Default is `10s`. ## session_timeout = "10s" @@ -141,7 +143,7 @@ [grpc] # `enable` indicates whether gRPC service should be enabled or not. - # Default is `false`. + # Default is `true`. ## enable = true # `enable_wallet` indicates whether Wallet service should be enabled or not. From 4ebace18608f00088824683a0afcad6c61af8074 Mon Sep 17 00:00:00 2001 From: Mostafa Date: Fri, 8 Mar 2024 23:36:26 +0800 Subject: [PATCH 2/2] chore: updating the YML comment --- config/example_config.toml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/config/example_config.toml b/config/example_config.toml index 8ee410a41..0e9f20aee 100644 --- a/config/example_config.toml +++ b/config/example_config.toml @@ -80,9 +80,9 @@ # `moniker` is a custom human-readable name for this node. ## moniker = "" - # `session_timeout` is a timeout for a download session to keep open. - # By sending a block download request, this timer starts and if there is no activity from the Node - # the session will get closed and try to get the block from another Node. + # `session_timeout` is a timeout for a download session to remain open. + # When a block download request is sent, this timer starts. If there is no activity from the target Node, + # the session will be closed after the timeout and try to get the block from another Node. # Default is `10s`. ## session_timeout = "10s"