Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address validation for the network module #524

Closed
b00f opened this issue Jun 20, 2023 · 2 comments
Closed

Address validation for the network module #524

b00f opened this issue Jun 20, 2023 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed network

Comments

@b00f
Copy link
Collaborator

b00f commented Jun 20, 2023

Description

We currently do not validate the network addresses in the config file. So, if a user enters an incorrect address, the node won't start (an incorrect listen address can even cause a system crash). We need to ensure all addresses, both relay and listen addresses, are valid in the SanityCheck function.

How To Reproduce

  1. Open the config file.
  2. Change the listen addresses and relay addresses to an incorrect string.

What Happened

The node didn't start. It may also cause a system crash.

Expected Behavior

Should return invalid address error before starting the node.
Write tests for the invalid addressess.

@b00f b00f added good first issue Good for newcomers help wanted Extra attention is needed network labels Jun 20, 2023
@kehiy
Copy link
Contributor

kehiy commented Jul 1, 2023

check: #565

@kehiy
Copy link
Contributor

kehiy commented Jul 4, 2023

@b00f we can close it now!

@b00f b00f closed this as completed Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed network
Projects
None yet
Development

No branches or pull requests

2 participants