Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet GetNewAddress API should return the public key #1346

Closed
b00f opened this issue Jun 17, 2024 · 0 comments · Fixed by #1350
Closed

Wallet GetNewAddress API should return the public key #1346

b00f opened this issue Jun 17, 2024 · 0 comments · Fixed by #1350
Assignees
@Ja7ad
Labels
good first issue Good for newcomers Wallet

Comments

@b00f
Copy link
Collaborator

b00f commented Jun 17, 2024

In Wallet service, GetNewAddress doesn't return the public key. It should set the public key.
This issue should be covered by test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ja7ad Ja7ad

Labels
good first issue Good for newcomers Wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(wallet): add public key on get new address Ja7ad/pactus
2 participants
@b00f @Ja7ad