Deps/node engines <16 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YOU54F
commented
May 18, 2023
package.json
Outdated
| @@ -20,7 +20,10 @@ | |||
| }, | |||
| "license": "MIT", | |||
| "peerDependencies": { | |||
| "msw": ">=0.35.0" | |||
| "msw": ">=0.36.9" | |||
There was a problem hiding this comment.
Didn't mean to add this, this is for a separate issue, to upgrade msw to 1.x
There was a problem hiding this comment.
It's probably a breaking change, so I think it's ok to do it at the same time as long as it's documented.
TimothyJones
approved these changes
May 19, 2023
package.json
Outdated
| @@ -20,7 +20,10 @@ | |||
| }, | |||
| "license": "MIT", | |||
| "peerDependencies": { | |||
| "msw": ">=0.35.0" | |||
| "msw": ">=0.36.9" | |||
There was a problem hiding this comment.
It's probably a breaking change, so I think it's ok to do it at the same time as long as it's documented.
| @@ -115,7 +115,7 @@ describe("API - With MSW mock generating a pact", () => { | |||
|
|
|||
| test("unhandled route", async () => { | |||
| await expect(API.getProduct("11")).rejects.toThrow( | |||
| /^connect ECONNREFUSED (127.0.0.1|::1):8081$/ | |||
| /^Error: connect ECONNREFUSED (127.0.0.1|::1):8081.*$/ | |||
There was a problem hiding this comment.
Can we improve this error message more?
There was a problem hiding this comment.
it’s just a generic error thrown from axios, ( in test code ), rather than users code. msw already logs out to the console that the request was unhandled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping support for Node versions below 16 in our project.
Why
Active development of Node 14 ended 21 Apr 2020
Active development of Node 16 ended 20 Apr 2021
Main problems of supporting EOL versions
Actions
Considering the aforementioned problems, it is recommended to drop support for versions from testing in our CI systems, for any versions out of security support
We use the following reference site https://endoflife.date
Tested Platforms
We attempt to be tested cross-platform/architecture, across multiple versions. See the
following table for progress.
Legend
Testing Matrix
## Notifying users
Update node_engines field to set to
Update testing matrix, to drop node 14
Add badges to
README, to notify user