Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial seems broken #42

Open
adamisom-ibotta opened this issue Feb 10, 2023 · 1 comment
Open

Tutorial seems broken #42

adamisom-ibotta opened this issue Feb 10, 2023 · 1 comment

Comments

@adamisom-ibotta
Copy link

Hey! I love tutorials
However in trying to follow the instructions in the docs here:

  1. First I ran make install and got make: *** No rule to make target npm', needed by install'. Stop. I inspected the Makefile and noticed it just runs npm install, so I ran that instead.
  2. Then I ran step 2, make_test_and_publish... and it seems to use a a GitHub secret I don't have access to? I get Error making request to https://testdemo.pactflow.io status=401 Unauthorized. and upon opening build.yml I notice (it's the same in 2 other .yml files): PACT_BROKER_BASE_URL: https://testdemo.pactflow.io
    PACT_BROKER_TOKEN: ${{ secrets.PACTFLOW_TOKEN_FOR_CI_CD_WORKSHOP }}
    But I don't have PACTFLOW_TOKEN_FOR_CI_CD_WORKSHOP. Should this part of build.yml actually be my organization's own URL and token? (my URL is ibotta.pactflow.io)

I do already have PACT_BROKER_BASE_URL and PACT_BROKER_TOKEN with the right values in my shell profile. Am I making some basic mistake here? What should the PACT_BROKER_TOKEN be.

@YOU54F
Copy link
Member

YOU54F commented Oct 10, 2024

Hey sorry for the super late reply

  1. This was my fault, the command should be underneath install: in the makefile, but you are correct that it just runs npm install. fixed in the latest commit
  2. If I run it locally without setting env vars PACT_BROKER_BASE_URL and PACT_BROKER_TOKEN, I get an error saying that No value provided for required options '--broker-base-url'

If you want to run in CI, update PACT_BROKER_BASE_URL: https://testdemo.pactflow.io to PACT_BROKER_BASE_URL: https://ibotta.pactflow.io in .github/workflows/build.yml and add a github actions repository secret called PACTFLOW_TOKEN_FOR_CI_CD_WORKSHOP with the value of your read/write token from PactFlow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants