Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to ruby backend #31

Closed
mattermack opened this issue Jan 16, 2018 · 5 comments
Closed

Migrate to ruby backend #31

mattermack opened this issue Jan 16, 2018 · 5 comments
Assignees
@nbrink91

Comments

@mattermack
Copy link
Contributor

This ticket is to migrate Pact-PHP to the ruby backend, making it easier to transition to v3.
@mattermack
Copy link
Contributor Author

Random notes

  • document for Matching in the new classes
    -- PhpPact\Consumer\Matcher\RegexMatcher | Match a value against its data type. | new TypeMatch(12) ?
  • build out more robust examples in tests
  • confirm provider examples are still accurate

Looking good

@bethesque
Copy link
Member

Give me a yell if you have any questions.

@mattermack
Copy link
Contributor Author

@bethesque, when working to verify our work, we ran into pact-foundation/pact-ruby-standalone#10

@mattermack
Copy link
Contributor Author

@nbrink91 ,

I worked through some minor documentation and updated examples on example pact-php-consumer

Do you want to do the honors of putting in a pull request for the merge to master? After that, I'll rename the example project, provide a link to it with better documentation, then we can tag v3!

@mattermack
Copy link
Contributor Author

Merged and closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nbrink91 nbrink91

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bethesque @mattermack @nbrink91