Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please rename consumerVersionTag to consumerVersionTags #218

Closed
bethesque opened this issue Apr 4, 2020 · 0 comments
Closed

Please rename consumerVersionTag to consumerVersionTags #218

bethesque opened this issue Apr 4, 2020 · 0 comments

Comments

@bethesque
Copy link
Member

consumerVersionTag gives the impression you should only be verifying one (even though it takes an array)

providerVersionTags the same (though the main usecase would just be one)
mefellows added a commit that referenced this issue Apr 6, 2020
@mefellows
feat: deprecate consumerVersionTag and providerVersionTag. Fixes #218
5a043a2
mefellows added a commit that referenced this issue Apr 7, 2020
@mefellows
feat: deprecate consumerVersionTag and providerVersionTag. Fixes #218
1150d63
TimothyJones added a commit that referenced this issue Apr 10, 2020
@TimothyJones
Merge pull request #219 from pact-foundation/fix/issue-218
491b5ba 
feat: deprecate consumerVersionTag and providerVersionTag. Fixes #218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bethesque