Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlReturn uses incorrect value #31

Closed
Sineaggi opened this issue Feb 12, 2021 · 2 comments
Closed

SqlReturn uses incorrect value #31

Sineaggi opened this issue Feb 12, 2021 · 2 comments
Labels

Comments

@Sineaggi
Copy link

In pr #27 SqlReturn changed
SQL_INVALID_HANDLE = -2,
to pub const INVALID_HANDLE: SqlReturn = SqlReturn(-1);

Is this correct?

@pacman82
Copy link
Owner

Thanks for politely phrasing it as a question, but no this is an accidental change. I screwed up. The downstream libraries pretty much prevent INVALID HANDLES by design, how on earth did you find this? Luckily it should not be to hard to write a test for this to prevent that error in the future.

@pacman82 pacman82 added the bug label Feb 12, 2021
@pacman82
Copy link
Owner

Fixed in 0.17.1. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants