-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downstream guide #838
Downstream guide #838
Conversation
Build succeeded. ✔️ pre-commit SUCCESS in 1m 15s |
Build succeeded. ✔️ pre-commit SUCCESS in 1m 15s |
6e90859
to
c448a58
Compare
Build succeeded. ✔️ pre-commit SUCCESS in 1m 13s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice the script for updating the docs. Thanks!
docs/cli/pull-from-upstream.md
Outdated
# `packit pull-from-upstream` | ||
|
||
This is a detailed documentation for the update functionality of packit. The | ||
command creates a new pull request in Fedora (or CentOS Stream) using a selected or latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
command creates a new pull request in Fedora (or CentOS Stream) using a selected or latest | |
command creates a new pull request in Fedora (or CentOS Stream) using the selected or the latest |
Not sure if this is better but "a selected" does not sounds to me...
docs/cli/pull-from-upstream.md
Outdated
## Requirements | ||
|
||
* Upstream git repository on GitHub/GitLab. | ||
* Upstream release (read, git tag) where version in spec file is equivalent to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Upstream release (read, git tag) where version in spec file is equivalent to | |
* Upstream release (both release and git tag) where version in spec file is equivalent to |
Not sure if this is what you mean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just mostly copied what we already have for propose-downstream
, but in fact git tag should be enough from CLI
c448a58
to
131164f
Compare
Build succeeded. ✔️ pre-commit SUCCESS in 1m 14s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a great improvement, only reviewed it briefly
every time. | ||
|
||
|
||
:::caution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this change that most of the retriggering commands are here now.
131164f
to
25942ed
Compare
Build succeeded. ✔️ pre-commit SUCCESS in 1m 11s |
Create a dedicated subsection for dist-git repository onboarding. Include also new information suggested in packit#802 Fixes packit#802
- add manual TOCs with most important section links - make the structure consistent - link the downstream one more visibly from upstream one
25942ed
to
d20162b
Compare
Build succeeded. ✔️ pre-commit SUCCESS in 1m 14s |
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 16s |
Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry. |
Fixes #802
Fixes #825
Fixes #665
When reviewing, it is probably best to go commit by commit.
TODO:
RELEASE NOTES BEGIN
N/A
RELEASE NOTES END