Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packit.yaml/issue_repository is confusing for pull-from-upstream #771

Closed
1 of 2 tasks
xsuchy opened this issue Nov 12, 2023 · 0 comments · Fixed by #779
Closed
1 of 2 tasks

packit.yaml/issue_repository is confusing for pull-from-upstream #771

xsuchy opened this issue Nov 12, 2023 · 0 comments · Fixed by #779
Assignees
Labels
area/fedora Related to Fedora ecosystem complexity/easy-fix No planning/thinking about design needed, should be finished in an hour. gain/low This doesn't bring that much value to users. impact/high This issue impacts multiple/lot of users. kind/bug Something isn't working. kind/documentation Documentation needs updates.

Comments

@xsuchy
Copy link
Contributor

xsuchy commented Nov 12, 2023

What happened? What is the problem?

I got this report
xsuchy/python-hwdata#5
that pull-from-upstream failed. Put aside why it failed. My problem is that pull-from-upstream failures should not be reported to upstream. In this case, I am the owner of upstream as well. But if upstream would be somebody else, they can be vary angry about it ("why you are bothering us about it, not our business").

This happened because I put issue_repository in packit.yaml in dist-git:
https://src.fedoraproject.org/rpms/python-hwdata/blob/rawhide/f/packit.yaml#_3
so one can argue it is my fault and PEBKAC.

But it was nowhere mentioned that dist-git import failures will be reported to issue_repository. And I checked
https://packit.dev/docs/configuration/downstream/pull_from_upstream#first-setup
https://packit.dev/docs/configuration#issue_repository

I propose:

[ ] amend https://packit.dev/docs/configuration#issue_repository alter last two sentences of the first paragraph to use for issue_repository the downstream repository. Maybe even with an exclamation mark.
[ ] alter https://packit.dev/docs/configuration/downstream/pull_from_upstream#first-setup to include in Caution box that you SHOULD NOT use the upstream issue repository there.
[ ] amend https://packit.dev/docs/configuration/downstream/pull_from_upstream#example to include downstream issue repository

What did you expect to happen?

No response

Example URL(s)

No response

Steps to reproduce

1.
2.
3.

Workaround

  • There is an existing workaround that can be used until this issue is fixed.

Participation

  • I am willing to submit a pull request for this issue. (Packit team is happy to help!)
@xsuchy xsuchy added the kind/bug Something isn't working. label Nov 12, 2023
@lbarcziova lbarcziova transferred this issue from packit/packit Nov 13, 2023
@lachmanfrantisek lachmanfrantisek added kind/documentation Documentation needs updates. area/fedora Related to Fedora ecosystem complexity/easy-fix No planning/thinking about design needed, should be finished in an hour. gain/low This doesn't bring that much value to users. impact/high This issue impacts multiple/lot of users. labels Nov 13, 2023
@lachmanfrantisek lachmanfrantisek moved this from new to backlog in Packit Kanban Board Nov 13, 2023
@lbarcziova lbarcziova changed the title packait.yaml/issue_repository is confusing for pull-from-upstream packit.yaml/issue_repository is confusing for pull-from-upstream Nov 22, 2023
lbarcziova added a commit to lbarcziova/packit.dev that referenced this issue Nov 22, 2023
@lbarcziova lbarcziova moved this from backlog to in-progress in Packit Kanban Board Nov 22, 2023
@lbarcziova lbarcziova moved this from in-progress to in-review in Packit Kanban Board Nov 23, 2023
@lbarcziova lbarcziova self-assigned this Nov 23, 2023
lbarcziova added a commit to lbarcziova/packit.dev that referenced this issue Nov 28, 2023
lbarcziova added a commit to lbarcziova/packit.dev that referenced this issue Nov 28, 2023
softwarefactory-project-zuul bot added a commit that referenced this issue Nov 28, 2023
Clarify issue_repository config option

Fixes #771

Reviewed-by: Nikola Forró
Reviewed-by: Laura Barcziová
@github-project-automation github-project-automation bot moved this from in-review to done in Packit Kanban Board Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fedora Related to Fedora ecosystem complexity/easy-fix No planning/thinking about design needed, should be finished in an hour. gain/low This doesn't bring that much value to users. impact/high This issue impacts multiple/lot of users. kind/bug Something isn't working. kind/documentation Documentation needs updates.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants